Fix lazy promise transitions #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A promise cannot be guarenteed to be transitioned from pending to timedout when requests come in after the timeout time. To compensate for this, we lazily transition promises on request if we see that the promise should be timedout, but is not. This rarely taken code path had two bugs. 1. On create promise request, a promise that is lazily timedout should return a 200 if strict is false and the idempotency keys match. 2. On complete promise request, a promise that is lazily timedout should return a 200 if strict is false. This PR also introduces a lazy scenario to DST to test the lazy code path. When this scenario is executed, we disable the time out promises coroutine and search promises request.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 55.34% 55.99% +0.64%
==========================================
Files 113 113
Lines 9885 9892 +7
==========================================
+ Hits 5471 5539 +68
+ Misses 4052 3987 -65
- Partials 362 366 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A promise cannot be guarenteed to be transitioned from pending to timedout when requests come in after the timeout time. To compensate for this, we lazily transition promises on request if we see that the promise should be timedout, but is not. This rarely taken code path had two bugs.
On create promise request, a promise that is lazily timedout should return a 200 if strict is false and the idempotency keys match.
On complete promise request, a promise that is lazily timedout should return a 200 if strict is false.
This PR also introduces a lazy scenario to DST to test the lazy code path. When this scenario is executed, we disable the time out promises coroutine and search promises request.